Conversation
Let's start from this side note: are you referring to the feedback I gave on the JSInterop articles? If so, where did my feedback issue go? I cannot find it in this repo. That was the 1st feedback I gave straight from the microsoft.learning, following your advice and then it made me confused that I cannot see it in the issue list. |
|
No, it has nothing to do with this PR. I only mention it because I'm killing that file on this PR in passing instead of opening up a new PR just for that one small task. |
ilonatommy
left a comment
There was a problem hiding this comment.
I approve but one does not see one's own errors. @pavelsavara, I believe you should see it.
| @@ -0,0 +1,199 @@ | |||
| --- | |||
There was a problem hiding this comment.
Note for Dan:
there should be a similar article about blazor with dotnet on WebWorker that points to https://github.com/ilonatommy/blazorWithDotnetOnWebWorker. Should we append it to this article? If we want a separate one, then where? https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/blazor?
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@danroth27 ... One of @ilonatommy's suggestions is "Wasm" over "WASM" when referring to WebAssembly generally (non-Blazor WebAssembly mentions). "WASM" was our convention from the start; however, I usually see "Wasm" around the Net. We only have it in a handful of spots. I'll open an issue to go with "Wasm" in those spots. UPDATE: Done! 👍 #36177 |
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
|
@ilonatommy ... This PR is updated for the sample app. The sample app is over on a PR here ... ... and you should probably run an 👁️ over it to see if I broke anything! 🙈😆 |
|
Ok ... We're good here WRT the sample because this already only said that the sample is available for .NET 10 or later, and we're not going to bother copying the .NET 10 samp back to the 8.0 and 9.0 folders. We do say that this will work for .NET 8 or later in the article, and my last commit updates the article versioning to surface this article for 8.0 or later. I also updated it to today's date. I'll merge this article to ⚡ LIVE ⚡ immediately after it goes in. |
|
@danroth27 ... If you have any patches after this merges, could you place them into an issue comment here or open a new issue from the bottom of the article? |
Fixes #36168
Ilona ... After your review/updates, I'll make a final pass and ping Dan to take a look tomorrow. I'm going OOF for a few hours now, but I'll be back this evening for Q&A/discussion if needed.
Side note: I'm deleting an article that should've gotten the 🔪 on #33156 😈. No harm ... no foul. It's just a floating markdown file. The content was moved. That article has been live at https://learn.microsoft.com/aspnet/core/client-side/dotnet-interop/wasm-browser-app ever since that PR was merged. Just need to 💀 the old markdown file here.
Internal previews