Skip to content

Update google-logins.md by using Google.Apis.Auth.AspNetCore3 package#33710

Merged
Rick-Anderson merged 18 commits into
dotnet:mainfrom
sharafabacery:patch-1
Jan 22, 2025
Merged

Update google-logins.md by using Google.Apis.Auth.AspNetCore3 package#33710
Rick-Anderson merged 18 commits into
dotnet:mainfrom
sharafabacery:patch-1

Conversation

@sharafabacery

@sharafabacery sharafabacery commented Sep 25, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

using https://developers.google.com/identity/sign-in/web/sign-in old link lead me for wrong integration
for that I search for new links and found it
for that I Contribute to help others to try this approach
This is my fist Contribution in open source ,I hope I do great.

Fixes #33815

Internal previews

📄 File 🔗 Preview link
aspnetcore/security/authentication/social/google-logins.md aspnetcore/security/authentication/social/google-logins

@sharafabacery
Update google-logins.md by using Google.Apis.Auth.AspNetCore3 package
73c1b84 
using https://developers.google.com/identity/sign-in/web/sign-in
old link lead me for wrong integration for that I search  for new links and found  it for that I Contribute to help others to try this approach
This is my fist Contribution in open source ,I hope I do great.
@sharafabacery

sharafabacery commented Sep 25, 2024

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

Rick-Anderson
Rick-Anderson suggested changes Oct 8, 2024
View reviewed changes
Comment thread aspnetcore/security/authentication/social/google-logins.md Outdated
Comment thread aspnetcore/security/authentication/social/google-logins.md Outdated
Rick-Anderson
Rick-Anderson reviewed Oct 8, 2024
View reviewed changes
Comment thread aspnetcore/security/authentication/social/google-logins.md Outdated
@Rick-Anderson Rick-Anderson marked this pull request as draft October 8, 2024 01:38
@sharafabacery sharafabacery marked this pull request as ready for review October 8, 2024 03:19
sharafabacery and others added 3 commits October 8, 2024 06:22
@sharafabacery @Rick-Anderson
Update aspnetcore/security/authentication/social/google-logins.md
c82175d 
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
@sharafabacery @Rick-Anderson
Update aspnetcore/security/authentication/social/google-logins.md
7a7b420 
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
@sharafabacery
Update google-logins.md
c17c9b0
sharafabacery
sharafabacery commented Oct 8, 2024
View reviewed changes

@sharafabacery sharafabacery left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Rick-Anderson
Rick-Anderson reviewed Oct 10, 2024
View reviewed changes
Comment thread aspnetcore/security/authentication/social/google-logins.md Outdated
@Rick-Anderson Rick-Anderson mentioned this pull request Oct 10, 2024
Open
Rick-Anderson
Rick-Anderson reviewed Oct 21, 2024
View reviewed changes
Comment thread aspnetcore/security/authentication/social/google-logins.md
wadepickett
wadepickett reviewed Oct 22, 2024
View reviewed changes
Comment thread aspnetcore/security/authentication/social/google-logins.md Outdated
wadepickett
wadepickett reviewed Oct 22, 2024
View reviewed changes
Comment thread aspnetcore/security/authentication/social/google-logins.md Outdated
wadepickett
wadepickett reviewed Oct 22, 2024
View reviewed changes
Comment thread aspnetcore/security/authentication/social/google-logins.md Outdated
wadepickett
wadepickett reviewed Oct 22, 2024
View reviewed changes
Comment thread aspnetcore/security/authentication/social/google-logins.md Outdated
@sharafabacery @wadepickett
Update aspnetcore/security/authentication/social/google-logins.md
899f90a 
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
@sharafabacery @wadepickett
Update aspnetcore/security/authentication/social/google-logins.md
c080f24 
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
wadepickett
wadepickett reviewed Oct 22, 2024
View reviewed changes

@wadepickett wadepickett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @sharafabacery! In addition to Rick's suggestions I have added a few minor ones.

Also, update the meta data for "ms.date: 3/3/2022" to the current the current date so readers will see that the content has been refreshed.

sharafabacery and others added 2 commits October 22, 2024 23:13
@sharafabacery @wadepickett
Update aspnetcore/security/authentication/social/google-logins.md
5aa75c1 
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
@sharafabacery @wadepickett
Update aspnetcore/security/authentication/social/google-logins.md
d7ef927 
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
@sharafabacery

sharafabacery commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

thanks both of you for review and help @Rick-Anderson @wadepickett

@wadepickett

wadepickett commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

@sharafabacery,
Is the intent to uplodaed the completed project at the following location before publishing the document update?:
https://github.com/dotnet/AspNetCore.Docs.Samples/tree/main/security/authorization/social + /GoogleAuthExample

@sharafabacery

sharafabacery commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

@wadepickett this dotnet/AspNetCore.Docs.Samples#264 issue contain pull request of the code I create

@Rick-Anderson

Rick-Anderson commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

I'm guessing we don't need a sample download.

@sharafabacery

sharafabacery commented Oct 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I can remove mr @Rick-Anderson

wadepickett
wadepickett reviewed Oct 29, 2024
View reviewed changes
Comment thread aspnetcore/security/authentication/social/google-logins.md Outdated
@wadepickett wadepickett self-requested a review October 29, 2024 18:37
wadepickett
wadepickett approved these changes Oct 29, 2024
View reviewed changes

@wadepickett wadepickett left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes pending to completion and review of the specific changes Rick requested.

@sharafabacery

sharafabacery commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

hello mr @Rick-Anderson is there any thing need to change?

@wadepickett

wadepickett commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

@Rick-Anderson, you also good with the changes?

@wadepickett

wadepickett commented Jan 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Rick-Anderson, you also good with these changes?

@Rick-Anderson Rick-Anderson merged commit 6aa1bba into dotnet:main Jan 22, 2025
@wadepickett wadepickett mentioned this pull request Jan 23, 2025
Closed
@wadepickett

wadepickett commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

@sharafabacery, thanks again!!! It is published now:
https://learn.microsoft.com/en-us/aspnet/core/security/authentication/social/google-logins

@wadepickett wadepickett mentioned this pull request Apr 24, 2025
Closed
@halter73 halter73 mentioned this pull request May 7, 2025
Open
@guardrex guardrex mentioned this pull request Apr 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wadepickett wadepickett wadepickett approved these changes

@Rick-Anderson Rick-Anderson Awaiting requested review from Rick-Anderson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update for Google.Apis.Auth.AspNetCore3

3 participants

@sharafabacery @wadepickett @Rick-Anderson