Document usage of System.Text.Encodings.Web package in ASP.NET Core 3.1#21057
Merged
Document usage of System.Text.Encodings.Web package in ASP.NET Core 3.1#21057
Conversation
BrennanConroy
approved these changes
Dec 28, 2020
Member
BrennanConroy
left a comment
There was a problem hiding this comment.
Looks fine, nit: this issue also applies to folks using SignalR on the server and client w/o Blazor, and maybe with WASM as well.
Collaborator
Author
|
AFAICT, this the only topic thus far to receive the feedback. I wonder if we can wait for the patch instead of adding more coverage. Do you think they'll get to it soon-ish? ... January/February? |
Member
|
I'm fine waiting. Hopefully it'll be fixed soon. As far as other feedback, I've gotten multiple issues on the aspnetcore repo about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21054
Thanks @rob-github! 🚀
I opened an issue to 🔪 this later ...
[5.0.2] Remove Blazor-SignalR tutorial encodings package content #21056
cc: @BrennanConroy ...
I'll wing it on the language given that we're still on the ⛄ holiday break 🎁. If you want to review and send suggestions for improvement, note them here. I'll patch the topic.UPDATE: Actually, best to wait for a sec to see if you have time for a quick 👀 now. I'll merge if you're not free right now. 👂I'm going to hit a few other quick content layout nits while I'm here. This topic will receive further updates of that ilk on a UE pass in January.