Fix @oneOf support broken with declaration kind other than type#8586
Merged
Conversation
🦋 Changeset detectedLatest commit: 60270c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
levrik
commented
Nov 8, 2022
4 tasks
n1ru4l
requested changes
Nov 8, 2022
n1ru4l
left a comment
Collaborator
There was a problem hiding this comment.
This is great, can you please add a changeset that describes this change?
Contributor
Author
|
@n1ru4l Added a changeset. I hope I did everything correct. |
n1ru4l
approved these changes
Nov 11, 2022
Collaborator
|
@levrik waiting for another review from @charlypoly - then we should be fine :) |
charlypoly
approved these changes
Nov 15, 2022
Contributor
Author
|
Thanks a lot for getting this merged! |
Contributor
|
@levrik Thank you for fixing this! 🙇🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On #8024 it was suggested to remove support for
declarationKindall together.Since this is a breaking change and probably won't happen soon and things are currently broken if using a
declarationKindother thantype, I would like to propose hard-coding@oneOfdeclarations totype, regardless of the configureddeclarationKindastypeis the only one working.Fixes #7938