Skip to content

Fix rerun-viewer example.#989

Merged
haixuanTao merged 1 commit intodora-rs:mainfrom
francocipollone:francocipollone/fix_rerun_viewer_example
Apr 29, 2025
Merged

Fix rerun-viewer example.#989
haixuanTao merged 1 commit intodora-rs:mainfrom
francocipollone:francocipollone/fix_rerun_viewer_example

Conversation

@francocipollone
Copy link
Copy Markdown
Contributor

@francocipollone francocipollone commented Apr 28, 2025 •
edited
Loading

Summary

This example had two issues:

  • the path to the dora rerun executable in the dataflow file was wrongly set
  • it wasn't able to be run via cargo run command (only using uv installation + dora build + dora run)

Test it

via cargo run:

cargo run --example rerun-viewer

via uv setup:

uv venv -p 3.11 --seed
uv pip install -e ../../apis/python/node --reinstall
dora build dataflow.yml --uv
dora run dataflow.yml --uv

@francocipollone
Fix rerun-viewer example.
242a2b5 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone force-pushed the francocipollone/fix_rerun_viewer_example branch from 8a98dc2 to 242a2b5 Compare April 28, 2025 18:40
haixuanTao
haixuanTao approved these changes Apr 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks!

@haixuanTao haixuanTao merged commit fd05e0b into dora-rs:main Apr 29, 2025
157 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@francocipollone @haixuanTao