Conversation
CLI Rework TODO ListCode Refactoring
Documentation
Node Hub Design & Architecture
Testing
Migration
|
|
Related: #551 |
|
So I feel like you want to make a lot of changes on the structure of the CI. Could we try to make as small PR as possible as it might be very hard to debug the CLI if something breaks. And I feel like this PR is already pretty good and might be conlicting with Philipps #901 |
Not exactly, I'm mentioning the CI just for tests (which is not presented yet) to make sure this PR does not break anything.
Totally agree, I think I should put the TODO list in an issue or discussion for tracking, instead of leaving it here. This PR should only change the CLI crate file structure.
Sorry for not investigating the existing work in advance but I actually started working on this earlier than the first commit. I don't think it's fully tested to be OK (as I stated before), so I kept it as drafted. I can do some compatibility fixes for #901 once it has been merged. 😊 |
|
Sorry I meant CLI :D But okay sounds good! |
|
@phil-opp @haixuanTao Would it be possible for someone to review this PR when convenient? |
|
I looked into it and it looks good to me. |
|
I’ve just merged the latest |
|
I pushed a commit to your branch to rename the |
phil-opp
left a comment
There was a problem hiding this comment.
Looks like the recent build module changes didn't survive the merge. Could you fix that?
Otherwise it looks good to me! Thanks!
|
@phil-opp Please review |
phil-opp
left a comment
There was a problem hiding this comment.
Thanks for the updates! Looks good to me overall, but we need to fix the CI errors before merging.
|
@phil-opp I modified the related part, plz review |
This pull request initiates a series of CLI rework efforts aimed at improving maintainability, consistency, and user experience.