Improve benchmark implementation & Add warning for discarding events#971
Merged
haixuanTao merged 3 commits intodora-rs:mainfrom Apr 22, 2025
Merged
Improve benchmark implementation & Add warning for discarding events#971haixuanTao merged 3 commits intodora-rs:mainfrom
haixuanTao merged 3 commits intodora-rs:mainfrom
Conversation
phil-opp
reviewed
Apr 16, 2025
Collaborator
phil-opp
left a comment
There was a problem hiding this comment.
The benchmark changes look good to me!
I'm not sure about the discard warning though (see my inline comment). What do you think @haixuanTao ?
haixuanTao
approved these changes
Apr 22, 2025
Collaborator
|
Looks good thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #966
This PR improves current benchmark implementation by increasing the queue size for throughput testing, and adding time gap between throughput tests of different sizes to ensure accurate measurement.
Besides, a warning message will be logged now on discarding events due to queue size limit.