Skip to content

Added E ruff flag for pydocstyle#958

Merged
haixuanTao merged 1 commit intodora-rs:mainfrom
7SOMAY:feat/add-ruff-flags
Apr 14, 2025
Merged

Added E ruff flag for pydocstyle#958
haixuanTao merged 1 commit intodora-rs:mainfrom
7SOMAY:feat/add-ruff-flags

Conversation

@7SOMAY
Copy link
Copy Markdown
Contributor

@7SOMAY 7SOMAY commented Apr 9, 2025

#878 Adde Ruff flags

The "E" flag is added inside the pyproject.toml inside the node-hub directory.

@haixuanTao
Copy link
Copy Markdown
Collaborator

Looks good thanks!

@haixuanTao haixuanTao merged commit b63b4c1 into dora-rs:main Apr 14, 2025
1 check passed
@phil-opp
Copy link
Copy Markdown
Collaborator

The node-hub CI job seems to be failing since this PR: https://github.com/dora-rs/dora/actions/runs/14442748704

Not sure if this is related though.

@haixuanTao
Copy link
Copy Markdown
Collaborator

Ah Indeed, I thought the CI runned on it, but it didn't.

@haixuanTao
Copy link
Copy Markdown
Collaborator

@7SOMAY why did you put [skip ci]?

@7SOMAY
Copy link
Copy Markdown
Contributor Author

7SOMAY commented Apr 15, 2025

@7SOMAY why did you put [skip ci]?

It was a blunder, I just checked this branch is merged to main but i was creating a script to fix that long line comment issue for which I was creating a script. And in the mean time this got merged.

Why I skipped CI?
Just to notify regarding this PR and keep working on that, once it’s done then I will ask for review this PR.
It’s my mistake, i should make this PR as draft.

@haixuanTao, Will the roll back can undo this issue?

@haixuanTao
Copy link
Copy Markdown
Collaborator

I mean it seems to me that you're communication of all those information has not been good.

@7SOMAY
Copy link
Copy Markdown
Contributor Author

7SOMAY commented Apr 15, 2025

I mean it seems to me that you're communication of all those information has not been good.

I am very sorry for that :’( I will improve my Ho-Ren-So part while development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants