Conversation
060331b to
e2c0ed4
Compare
9a32307 to
fc93e88
Compare
69c686f to
a15c447
Compare
a15c447 to
1279aa5
Compare
3b1317c to
1aeeec3
Compare
12bd998 to
0ec1214
Compare
|
one interesting feature of maturin zig is that they also link eternal dynamic library such as libdav1d-dev, making dora node not requiring system dependency when installed from pip, making it less likely fail. I have only currently added this support for amd64 but we will in the future also be able to support all platform. |
If you link against a dynamic library, you normally need to have it installed on the target system too. This sounds like zig is somehow able to link the dynamic libraries statically, but I'm not sure how that is possible. Do you have any links that explain this feature? |
I meam zig copies the dynamic link into the wheel and so redistribute it at the same time, see: https://github.com/dora-rs/dora/actions/runs/14379049575/job/40318281234#step:9:2415 It's still dynamically loaded but from a copied version |
|
Ah, interesting! Does this happen automatically when a shared library is linked or is there any config required? |
It seems automatic. Only thing I have done is copy the shared library into its searched path: dora/.github/workflows/node-hub-ci-cd.yml Lines 58 to 59 in 0ec1214 |
Minor license fixes as well as documentation updates!