Skip to content

Implemented dora-cotracker node#931

Merged
haixuanTao merged 5 commits intodora-rs:mainfrom
ShashwatPatil:cotracker
Apr 7, 2025
Merged

Implemented dora-cotracker node#931
haixuanTao merged 5 commits intodora-rs:mainfrom
ShashwatPatil:cotracker

Conversation

@ShashwatPatil
Copy link
Copy Markdown
Contributor

This pull request introduces a new Dora node for real-time object tracking using Facebook's CoTracker model addressing #921 . The changes include new features, configuration files, and documentation to support the implementation and usage of this node.

Key changes include:

New Features and Implementation:

  • Added the main implementation of the VideoTrackingNode class in dora_cotracker/main.py, which includes methods for initializing the CoTracker model, handling mouse clicks for point selection, processing video frames for tracking, and running the main loop.

Configuration and Setup:

  • Added a pyproject.toml file to define the project metadata, dependencies, and development dependencies, as well as to configure the ruff linter.
  • Created a demo.yml configuration file to set up a sample data flow for the node, including camera input, tracker, and display nodes.

Documentation and Testing:

  • Added a comprehensive README.md file that includes an overview of the node, installation instructions, usage examples, API reference, and development guidelines.
  • Added a basic test file tests/test_dora_cotracker.py to ensure the main function can be imported and run, catching runtime exceptions when not running in a Dora dataflow.

Copy link
Copy Markdown
Collaborator

@Hennzau Hennzau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot for that! 😁

Copy link
Copy Markdown
Collaborator

@Hennzau Hennzau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Hennzau
Copy link
Copy Markdown
Collaborator

Hennzau commented Apr 2, 2025

again @haixuanTao there is no change outside of node-hub, so the required CI is not triggered :)

@Hennzau
Copy link
Copy Markdown
Collaborator

Hennzau commented Apr 2, 2025

@ShashwatPatil Maybe you can put the demo video on the PR ;)

@ShashwatPatil
Copy link
Copy Markdown
Contributor Author

@ShashwatPatil Maybe you can put the demo video on the PR ;)

I will make a demo video; but where should I put it? and I was thinking of making a example that would uses yolo and track them using the co-tracker? How does this sound.

P.S it will take some time from my end to make them, due to college work 🤧... but will try to make them on coming Friday

@Hennzau
Copy link
Copy Markdown
Collaborator

Hennzau commented Apr 2, 2025

@ShashwatPatil Maybe you can put the demo video on the PR ;)

I will make a demo video; but where should I put it? and I was thinking of making a example that would uses yolo and track them using the co-tracker? How does this sound.

P.S it will take some time from my end to make them, due to college work 🤧... but will try to make them on coming Friday

Great!! Don't worry, take your time. You can either add the media directly on the PR (drag and drop will upload it), or make a YT video and put the link here!

@ShashwatPatil
Copy link
Copy Markdown
Contributor Author

@Hennzau @haixuanTao I have added the link to the demo video in readme.

@Hennzau Hennzau requested a review from haixuanTao April 4, 2025 19:50
@haixuanTao
Copy link
Copy Markdown
Collaborator

Looks great, thanks!

@haixuanTao haixuanTao merged commit 4cacd1f into dora-rs:main Apr 7, 2025
110 checks passed
@ShashwatPatil ShashwatPatil deleted the cotracker branch May 20, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants