Don't send AllInputsClosed event to source nodes#1302
Merged
haixuanTao merged 1 commit intomainfrom Jan 16, 2026
Merged
Conversation
This keeps the event channel open for source nodes so that they can receive manual stop events. It also simplifies our policy around dealing with event stream closure: All nodes (including source nodes) should now exit once the event stream closes (i.e. after receiving a stop event of any kind).
haixuanTao
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps the event channel open for source nodes so that they can receive manual stop events. It also simplifies our policy around dealing with event stream closure: All nodes (including source nodes) should now exit once the event stream closes (i.e. after receiving a stop event of any kind).
Note that this is technically a breaking change. However, we don't expect that there are nodes that rely on the immediate stop event and event stream closure. Because of this, we plan to treat this as a bugfix without doing a semver-breaking release. We should mention it prominently in the release docs though.
Alternative to #992
Fixes #500