Make adding more NodeEvent variants backwards-compatible (take 2)#1278
Open
Make adding more NodeEvent variants backwards-compatible (take 2)#1278
Conversation
Ignore unknown event types during deserialization.
Instead of providing it via the Python node API. This approach has the advantage that it works consistently across languages. For example, the Rust node API was not setting these fields, leading to log messages without a node_id. This commit fixes that.
It will block forever.
Also: Fall back to fields when `target` is the empty string
Conflicts resolved: - .github/workflows/ci.yml: took main's restructured CI steps with --stop-after flags and new test steps, preserved PR's RUST_LOG: debug on Python node example step - apis/python/node/src/lib.rs: took main's async zenoh-based logging rewrite, preserved PR's error handling (PyResult return types, closed-stream checks on recv/try_recv/recv_async_timeout) - binaries/daemon/src/lib.rs: took main's FinishDataflowWhen return type, preserved PR's tracing::info and grace-period warning messages - binaries/daemon/src/spawn.rs: accepted main's deletion (file was split into spawn/ module); PR's log metadata changes are obsolete with the new zenoh logging architecture Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore unknown event types during deserialization.
New version of #1273