Skip to content

fix(deps): add scikit-learn to resolve #1264#1265

Merged
haixuanTao merged 1 commit intodora-rs:mainfrom
kush124k:fix-sklearn-error
Dec 17, 2025
Merged

fix(deps): add scikit-learn to resolve #1264#1265
haixuanTao merged 1 commit intodora-rs:mainfrom
kush124k:fix-sklearn-error

Conversation

@kush124k
Copy link
Copy Markdown
Contributor

📝 Description

This PR addresses a compatibility issue between thop and recent versions of scikit-learn.
The thop library relies on older sklearn import paths that have been deprecated/removed in newer releases, causing the build/execution to fail.

🔧 Changes Made

  • Patched the thop usage/imports to align with the current scikit-learn API.
  • Ensured the dependency chain resolves correctly without downgrading scikit-learn explicitly (if applicable).

🎯 Context

  • Issue: thop uses old sklearn methods which cause ImportError or AttributeError in modern environments.
  • Fix: Updated the relevant logic to support the latest scikit-learn.

✅ Checklist

  • Code runs locally.
  • Synced with upstream main.

@phil-opp
Copy link
Copy Markdown
Collaborator

The diff includes a lot of unrelated changes. Not sure how this happened. Please try rebasing your branch on upstream/main.

@kush124k kush124k reopened this Dec 16, 2025
@haixuanTao haixuanTao merged commit 9d0218b into dora-rs:main Dec 17, 2025
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants