feat: implement dora node list command with metrics and filtering (#1202)#1262
Merged
phil-opp merged 1 commit intodora-rs:mainfrom Dec 16, 2025
Merged
Conversation
fab95fb to
05bd1dc
Compare
Contributor
Author
|
can you please review this PR. @phil-opp |
phil-opp
approved these changes
Dec 16, 2025
Collaborator
phil-opp
left a comment
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds dora node list command (#1202) to list all currently running nodes and their resource metrics. The command offers both table and JSON formats. It shows the node name, status, PID, CPU usage, and memory consumption. Users can filter by dataflow name or UUID.
The implementation uses current metrics collection system. The daemon collects process metrics every 2 seconds with the sysinfo crate. It sends these metrics to the coordinator through NodeMetrics events. The CLI queries the coordinator using the GetNodeInfo request/reply protocol to get node information and formats it for display.