Skip to content

Remove default zenoh endpoint peer config#1260

Merged
haixuanTao merged 3 commits intomainfrom
remove-endpoint-zenoh-config
Dec 18, 2025
Merged

Remove default zenoh endpoint peer config#1260
haixuanTao merged 3 commits intomainfrom
remove-endpoint-zenoh-config

Conversation

@phil-opp
Copy link
Copy Markdown
Collaborator

@phil-opp phil-opp commented Dec 12, 2025 •
edited
Loading

With the default config we get a lot of CONNECTION_TO_SELF errors since eclipse-zenoh/zenoh#2110 was merged.

@phil-opp
Remove default endpoint peer config
6842902 
Fails with `CONNECTION_TO_SELF` error since eclipse-zenoh/zenoh#2110
@phil-opp phil-opp requested a review from haixuanTao December 12, 2025 11:41
@phil-opp
Copy link
Copy Markdown
Collaborator Author

phil-opp commented Dec 12, 2025

The diff looks a bit weird. I basically removed the first if branch, so that we go directly into the else branch.

@haixuanTao
Copy link
Copy Markdown
Collaborator

haixuanTao commented Dec 13, 2025

But I think the scouting doesn't work on macOS and this PR removes it and revert to default. Is this what this PR aims to do?

@phil-opp
Copy link
Copy Markdown
Collaborator Author

phil-opp commented Dec 16, 2025

But I think the scouting doesn't work on macOS

Is there some issue with more details on this? I looked through the zenoh repo but didn't find anything related.

@haixuanTao
Copy link
Copy Markdown
Collaborator

haixuanTao commented Dec 17, 2025

No, I don't really know why and haven't investigated beyond the fact that I think is what breaking the CI/CD

@phil-opp
Copy link
Copy Markdown
Collaborator Author

phil-opp commented Dec 17, 2025

So it seems like it was the other way around: The else branch also disabled multicast scouting on macos: https://github.com/dora-rs/dora/pull/1260/changes#diff-a2231c167364419201c67cde2890e158d1faea556e39524e28913cb80b983aceL84-L91

Turns out that was the reason why the CI was failing. I removed that exception in bdf57c6 and now the macos CI jobs pass as well.

@haixuanTao haixuanTao merged commit 42ae98d into main Dec 18, 2025
27 checks passed
@haixuanTao haixuanTao deleted the remove-endpoint-zenoh-config branch December 18, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-opp @haixuanTao