Skip to content

Fix topic statistcs#1247

Merged
phil-opp merged 3 commits intodora-rs:mainfrom
sjfhsjfh:mivik-topic
Dec 4, 2025
Merged

Fix topic statistcs#1247
phil-opp merged 3 commits intodora-rs:mainfrom
sjfhsjfh:mivik-topic

Conversation

@sjfhsjfh
Copy link
Copy Markdown
Contributor

@sjfhsjfh sjfhsjfh commented Dec 3, 2025

The previous topic employed frequency as its metric, which might be ambiguous when computing average. Also added a sparkline chart as a straightforward monitoring tool.

Copy link
Copy Markdown
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me overall. I haven't checked the rendering code in detail though.

@Mivik Could you also give this a quick review please, an the original author of the dora topic subcommand.

@Mivik
Copy link
Copy Markdown
Contributor

Mivik commented Dec 4, 2025

LGTM! Tested it out locally and ui looks fine.

@phil-opp
Copy link
Copy Markdown
Collaborator

phil-opp commented Dec 4, 2025

Thanks!

@phil-opp phil-opp merged commit 8a7830c into dora-rs:main Dec 4, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants