Conversation
place the rust ros2 example standalone add ros2 rust example align with ros2's official minimal example Signed-off-by: drindr <dreamchancn@qq.com>
Signed-off-by: drindr <dreamchancn@qq.com>
|
And the new examples makes the CI verification for ros2-bridge more complete. |
…check Signed-off-by: drindr <dreamchancn@qq.com>
Signed-off-by: drindr <dreamchancn@qq.com>
Signed-off-by: drindr <dreamchancn@qq.com>
phil-opp
left a comment
There was a problem hiding this comment.
Looks good overall, thanks!
|
My bad😭️ |
Signed-off-by: drindr <dreamchancn@qq.com>
b2d7259 to
0ba9864
Compare
|
Ping @phil-opp. I think it is ready to be merged. Or do you have any other suggestions? |
|
Looks good now! CI was failing, but the failures looked spurious so I restarted the failed ones. Now everything passes. Thanks again! |
|
I think there is some issue with the documentation as the readme hasn't been updated: cargo run --example python-ros2-dataflow --features="ros2-examples"Could you make a PR and make sure that all instance that has been renamed keep on functioning? Thanks in advance. See: https://discord.com/channels/1146393916472561734/1161298298271965295/1447454126949667001 |
Okay. And I think the feature gate can be removed as well, as those examples have been moved into the |
Place the ros2-bridge examples into a separate folder and provide more examples aligning with ROS2's minimal examples mentioned in #1194.