feat: c++ arrow interface with id and metadata#1169
Conversation
|
Is using a file type as a suffix something very common in cpp? It seems to be a bit raw. Does cpp implements a standard dictionary object? |
|
I think it's impossible to return an auto metadata = extract_metadata();
std::optional<> val = metadata.get(key); |
|
@haixuanTao This new approach now provides access to metadata dict through getter and setter method. Due to constraints of the FFI interface I have to implement all the metadata types manually. If we want better interface, we can add a wrapper from C++ side to wrap the raw interface into template functions. |
haixuanTao
left a comment
There was a problem hiding this comment.
This looks awesome to me!
Could @phil-opp take a look maybe? :)
Adds a new function to dora C++ interface to make retrieving the complete information (id, metadata, arrow data) possible. Metadata will be serialized to json.