Simplify example run.rs files to use dora_cli build and run functions by haixuanTao · Pull Request #1165 · dora-rs/dora

haixuanTao · 2025-10-22T04:47:52Z

This commit standardizes all example run.rs files to use the dora_cli::build and dora_cli::run functions directly instead of spawning cargo commands with tokio::process::Command. This simplification:

Removes custom build_dataflow and run_dataflow helper functions
Uses dora_cli::{build, run} API directly
Standardizes error messages for tracing setup to use .wrap_err("failed to set up tracing subscriber")
Reduces code duplication across all examples
Makes the codebase more maintainable

Modified examples:

All Rust examples (rust-dataflow, rust-dataflow-git, rust-dataflow-url, rust-ros2-dataflow)
All C/C++ examples (c-dataflow, c++-dataflow, c++-arrow-dataflow, c++-ros2-dataflow, cmake-dataflow)
All Python examples (python-dataflow, python-operator-dataflow, python-ros2-dataflow)
Benchmark example

Total reduction: 289 lines of boilerplate code removed.

🤖 Generated with Claude Code

This commit standardizes all example run.rs files to use the `dora_cli::build` and `dora_cli::run` functions directly instead of spawning cargo commands with tokio::process::Command. This simplification: - Removes custom `build_dataflow` and `run_dataflow` helper functions - Uses `dora_cli::{build, run}` API directly - Standardizes error messages for tracing setup to use `.wrap_err("failed to set up tracing subscriber")` - Reduces code duplication across all examples - Makes the codebase more maintainable Modified examples: - All Rust examples (rust-dataflow, rust-dataflow-git, rust-dataflow-url, rust-ros2-dataflow) - All C/C++ examples (c-dataflow, c++-dataflow, c++-arrow-dataflow, c++-ros2-dataflow, cmake-dataflow) - All Python examples (python-dataflow, python-operator-dataflow, python-ros2-dataflow) - Benchmark example Total reduction: 289 lines of boilerplate code removed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

phil-opp

Nice!

We should make the test functions sync now though, as both the build and run functions are blocking. I assume that's also why the CI fails.

phil-opp · 2025-10-28T13:51:35Z

The log output is very mangled unfortunately: https://github.com/dora-rs/dora/actions/runs/18831862990/job/53724683004?pr=1165

runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout warning: missing documentation for a struct
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout --> libraries/message/src/descriptor.rs:515:1
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout |
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout 515 | pub struct RuntimeNode {
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout | ^^^^^^^^^^^^^^^^^^^^^^
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout warning: missing documentation for a struct
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout --> libraries/message/src/descriptor.rs:521:1
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout |
runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout 521 | pub struct OperatorDefinition {

haixuanTao · 2025-11-03T14:35:00Z

The log output is very mangled unfortunately: https://github.com/dora-rs/dora/actions/runs/18831862990/job/53724683004?pr=1165

runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout runtime-node: stdout

So FYI, there was a std::current_exe() in the daemon for spawning the runtime process that ended up recursively calling the cargo example process in a loop so I replaced it with a search for dora node.

haixuanTao · 2025-11-03T14:36:47Z

I think those changes should make the CI 30% faster compared to before as the example are now less compile exhaustive.

phil-opp · 2025-11-05T13:26:42Z

binaries/daemon/src/spawn.rs

                    } else {
                        let mut cmd = tokio::process::Command::new(
-                            std::env::current_exe()
+                            which::which("dora")


We should hightlight this change in the changelog for our next release because this might break people that have installed dora under a different name (e.g. named the executable dora-0.13.3).

phil-opp approved these changes Oct 22, 2025

View reviewed changes

haixuanTao added 2 commits October 27, 2025 12:24

Fix run example to make it simpler

448fc9c

Remove tracing that is conflicting with the daemon

0ea4d2e

haixuanTao added 3 commits November 3, 2025 18:10

fix run.rs extra argument

19ad976

fix runtime node spawn

da2593f

Install dora within the examples

6c7cbb6

haixuanTao force-pushed the simplifying-example-with-build-and-run-function-from-cli branch from 9530de8 to 6c7cbb6 Compare November 3, 2025 13:19

haixuanTao merged commit 54b49f7 into main Nov 4, 2025
27 checks passed

haixuanTao deleted the simplifying-example-with-build-and-run-function-from-cli branch November 4, 2025 12:32

phil-opp reviewed Nov 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify example run.rs files to use dora_cli build and run functions#1165

Simplify example run.rs files to use dora_cli build and run functions#1165
haixuanTao merged 6 commits intomainfrom
simplifying-example-with-build-and-run-function-from-cli

haixuanTao commented Oct 22, 2025

Uh oh!

phil-opp left a comment

Uh oh!

phil-opp commented Oct 28, 2025

Uh oh!

haixuanTao commented Nov 3, 2025

Uh oh!

haixuanTao commented Nov 3, 2025

Uh oh!

Uh oh!

phil-opp Nov 5, 2025

Uh oh!

haixuanTao Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

haixuanTao commented Oct 22, 2025

Uh oh!

phil-opp left a comment

Choose a reason for hiding this comment

Uh oh!

phil-opp commented Oct 28, 2025

Uh oh!

haixuanTao commented Nov 3, 2025

Uh oh!

haixuanTao commented Nov 3, 2025

Uh oh!

Uh oh!

phil-opp Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

haixuanTao Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants