Merged
Conversation
1006a4d to
a1f4341
Compare
dieu-detruit
reviewed
Oct 3, 2025
| dora-ros2-bridge-python = { path = "libraries/extensions/ros2-bridge/python" } | ||
| # versioned independently from the other dora crates | ||
| dora-message = { version = "0.5.0", path = "libraries/message" } | ||
| dora-message = { version = "0.6.0", path = "libraries/message" } |
Contributor
There was a problem hiding this comment.
Thank you for dora-rs devleopment.
This change causes imcompatible message version via old nodes and new nodes like:
xxxx: stdout 2: version mismatch: message format v0.5.0 is not compatible with expected message format v0.6.0
I think it would be better if this change is done in a major or minor version up, not in a patch version up!
Collaborator
Author
There was a problem hiding this comment.
I understand. I think in the future, we'll do minor version up to keep semver compatibility. Sorry!
DO you need help with upgrading nodes?
Contributor
There was a problem hiding this comment.
I fixed this just by upgrading all the nodes and dora-cli!
I've just commented on this for better ecosystem management
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.