Merged
Conversation
haixuanTao
approved these changes
Sep 16, 2025
Collaborator
|
That makes total sense to me. Thanks! |
Collaborator
|
@Mivik Good catch, thanks a lot for debugging and fixing this! The mistake was introduced in 90733aa#diff-0c87941bd66817ea1d1420cbe280fa9b9f26d21c99dc91ca7a76a370e8bb57ae, where I apparently forgot to change the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prior to this PR,
run_build_commandcontains wrong implementation which callscmd.spawn()andcmd.status()sequentially, and since both invocations execute the command, each build command is executed twice. The issue is uncovered during my investigation of issue #1090 .This PR addresses the issue by replacing
cmd.status()withchild.wait(). Additionally, it also changes the process backend fromstdtotokioto improve concurrency.Since the issue has been resolved, #1137 is reverted to reduce verbosity of CI logs.
Related
Fixes #1090