Skip to content

Run cargo update#1109

Merged
phil-opp merged 5 commits intomainfrom
cargo-update
Aug 27, 2025
Merged

Run cargo update#1109
phil-opp merged 5 commits intomainfrom
cargo-update

Conversation

@phil-opp
Copy link
Copy Markdown
Collaborator

@phil-opp phil-opp commented Aug 27, 2025 •
edited
Loading

Updates our Rust dependencies to their latest compatible versions.

@phil-opp
Downgrade mistral-rs and tokenizers again to fix build errors
492937c 
The latest `mistral-rs` version requires at least Rust 1.86, but we set a msrv of 1.85.

The v0.5.0 release of mistral-rs doesn't compile with the latest compatible tokenizers version because of huggingface/tokenizers#1855, so a manual downgrade was necessary.
@phil-opp
Downgrade and pin rustypot because of breaking changes in latest re…
5018b0d 
…lease

See pollen-robotics/rustypot#98
@phil-opp phil-opp requested a review from haixuanTao August 27, 2025 11:15
@phil-opp phil-opp mentioned this pull request Aug 27, 2025
Closed
@phil-opp
Copy link
Copy Markdown
Collaborator Author

phil-opp commented Aug 27, 2025

The Windows CI errors are caused by Atostek/RustDDS#375. The pnet library has some additonal requirements on Windows.

We have two options:

  • Install the additional dependencies and require all users to do it too.
  • Pin rustdds to an older version.

The second option is easier of course, but this would mean that an older rustdds version is used on Unix systems too. According to this comment from the linked issue, the multicast support might be a requirement:

The only standard-specified, and therefore interoperable, Discovery method between DDS implementations is the SPDP and SEDP protocols from the RTPS specification. In order for them to work without address configuration beforehand, they need multicast. That is why multicast should be included and be enabled by default.

It is plausible to make it configurable, e.g. to turn it off completely, but not as a default.

What do you think @haixuanTao @heyong4725 ?

@haixuanTao
Copy link
Copy Markdown
Collaborator

haixuanTao commented Aug 27, 2025

I would pin RustDDS to the older version for now.

And probably add a todo for later.

haixuanTao
haixuanTao approved these changes Aug 27, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@phil-opp phil-opp merged commit df4a241 into main Aug 27, 2025
158 checks passed
@phil-opp phil-opp deleted the cargo-update branch August 27, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-opp @haixuanTao