Merged
Conversation
phil-opp
reviewed
Aug 26, 2025
Collaborator
phil-opp
left a comment
There was a problem hiding this comment.
Thanks, looks useful! I like that it just generates a YAML file and invokes the normal dora CLI commands, so we don't need any special handling in dora itself.
I haven't tried the new APIs or examples yet, but I skimmed the code a bit. I noticed a few things that could be improved, see my inline comments.
haixuanTao
reviewed
Sep 25, 2025
Implement run, start, and stop methods in doraflow API to execute dataflows. Add translation_dataflow.py example. Create API documentation for doraflow. Remove generated artifacts from the repository.
Rename directory examples/python-api-dataflow to examples/doraflow. Update DORAFLOW_API_DESIGN.md to remove set_entry_point method.
- Add doraflow API announcement to 'Latest News' section. - Update 'Python API' link to point to new doraflow documentation. - Update 'Examples' section to include doraflow examples and update YOLO example path.
4eb641d to
4e5887e
Compare
phil-opp
approved these changes
Sep 25, 2025
Collaborator
phil-opp
left a comment
There was a problem hiding this comment.
Looks good to me overall!
Comment on lines
+50
to
+52
| print("Skipping build and run steps due to NO_BUILD env var") | ||
| print("Running dataflow.yml") | ||
| run("dataflow.yml", uv=True) |
Collaborator
There was a problem hiding this comment.
The run step is not actually skipped, is it?
phil-opp
reviewed
Sep 25, 2025
| python simple_example.py | ||
| ``` | ||
|
|
||
| To skip the build and run steps (useful for testing YAML generation only): |
Collaborator
There was a problem hiding this comment.
This also needs adjustment
Collaborator
|
I opened #1147 to fix the "Check for specified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the new doraflow Pythonic API, providing an imperative and developer-friendly way to define dora dataflows directly within Python.
Key changes include:
doraflowAPI: Implemented Dataflow, Node, and Operator classes for a Pythonic dataflow definition.