Updates to rerun 0.24.0 + message type proposal#1096
Merged
haixuanTao merged 13 commits intodora-rs:mainfrom Aug 13, 2025
Merged
Updates to rerun 0.24.0 + message type proposal#1096haixuanTao merged 13 commits intodora-rs:mainfrom
haixuanTao merged 13 commits intodora-rs:mainfrom
Conversation
Collaborator
|
that's fantastic! Thanks a lot! I think primitive definitely works! |
Collaborator
|
Would it be possible to make this a soft breaking change by trying to resolve primitive using topic name if not present, making it easier for you and for everyone to slowly change into this new format? |
Contributor
Author
|
Yes, I think we could catch this case and handle as before. Let me give it a shot. |
Contributor
Author
|
Made the changes soft breaking |
haixuanTao
reviewed
Aug 12, 2025
Collaborator
haixuanTao
left a comment
There was a problem hiding this comment.
Shall we try to merge the dora-rerun with proposed typed metadata?
apis/rust/node/src/node/mod.rs
Outdated
| clock: Arc<uhlc::HLC>, | ||
|
|
||
| sent_out_shared_memory: HashMap<DropToken, ShmemHandle>, | ||
| sent_out_shared_memory: HashMap<DropToken, (ShmemHandle, uhlc::Timestamp)>, |
Collaborator
There was a problem hiding this comment.
I understand this is an ongoing deep dive but in order to stabilise the rerun API first, could we remove this commit?
haixuanTao
approved these changes
Aug 13, 2025
Collaborator
|
Thanks @rozgo for everything! Sorry I was a bit busy lately! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a breaking change to
dora-rerunthat replaces the input-name-based visualization system with an explicit primitive-based metadata system. This change was motivated by real-world requirements from complex robotics applications, specifically the dora_quad port of the Peng quadrotor framework.Key Changes
1. Core Architecture Change
primitivefield required in metadata (e.g.,metadata: { "primitive": "image" })2. Updated Dependencies
3. New Features
4. Migration Work
opencv-video-capture→"primitive": "image"dora-yolo→"primitive": "boxes2d"dora-keyboard→"primitive": "text"dora-distil-whisper→"primitive": "text"dora-argotranslate→"primitive": "text"dora-sam2→"primitive": "masks"dora-qwen2-5-vl→"primitive": "text"dora-qwenvl→"primitive": "text"dora-reachy2→ appropriate primitives for each outputdora-dav1d→"primitive": "image"dora-rav1e→"primitive": "image"5. Example Updates
-eflag in dataflow pip installsexamples/rerun-viewer/dataflow.ymlexamples/camera/dataflow_rerun.ymlexamples/python-dataflow/dataflow.ymlexamples/python-multi-env/dataflow.ymlexamples/keyboard/dataflow.yml(requires Linux/X11)examples/translation/*examples/reachy2-remote/dataflow_reachy.ymlexamples/lebai/graphs/dataflow_full.ymlexamples/av1-encoding/*Breaking Changes
primitivemetadata field. See the migration guide in the README for details.NOTE: Last commit makes this soft-breaking now.
Benefits
More details in this README.
Cons
Testing