[node-hub] opencv-plot: allow specifying encoding and bbox format in uppercase letters#1075
Merged
haixuanTao merged 1 commit intodora-rs:mainfrom Jul 21, 2025
Conversation
Contributor
Author
|
I've tested with this dataflow.yaml and it works. nodes:
- id: camera
build: cargo install --git https://github.com/kornia/dora-nodes-hub kornia-gst-capture
path: kornia-gst-capture
inputs:
tick: dora/timer/millis/30
outputs:
- frame
env:
SOURCE_TYPE: "webcam"
SOURCE_URI: "/dev/video0"
IMAGE_COLS: "640"
IMAGE_ROWS: "480"
SOURCE_FPS: "30"
PIXEL_FORMAT: "YUYV"
- id: opencv-plot
build: uv add --branch node_hub-opencv_plot-allow_uppercase_encoding_and_bbox_format git+https://github.com/dieu-detruit/dora.git#subdirectory=node-hub/opencv-plot
path: opencv-plot
inputs:
image: camera/frame |
haixuanTao
approved these changes
Jul 21, 2025
Collaborator
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target
opencv-plot on node-hub.
Problem
Another node on hub like kornia-v4l-capture may output encoding in uppercase (e.g. RGB8)
The current code only allows lower case (rgb8) and causes error between kornia-v4l-capture and this node.
This PR
Take lowercase string for encodings and bbox formats before compairing them.