Merged
Conversation
Collaborator
|
FYI, updating rust edition makes it hard to use dora node api with older rust version. I would maybe wait to upgrade rust edition unless it is strictly necessary |
Collaborator
|
I think the Rust 2024 edition was introduced in Rust 1.85, which is the lowest Rust version we support. So it should be ok. |
Collaborator
phil-opp
approved these changes
Jul 30, 2025
Collaborator
phil-opp
left a comment
There was a problem hiding this comment.
Looks good to me!
I'll try to clean up the git history before merging.
Contributor
Author
Collaborator
|
Depends on the PR. For example, I prefer multiple commits for larger PRs that can be split into multiple separate steps. This way, the commits on the main branch are smaller and For this PR, keeping the the formatting and clippy changes in separate commits makes the history and diffs easier to read in my opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.