Skip to content

Improve build logging#1067

Merged
phil-opp merged 3 commits intomainfrom
improve-logging
Jul 23, 2025
Merged

Improve build logging#1067
phil-opp merged 3 commits intomainfrom
improve-logging

Conversation

@phil-opp
Copy link
Copy Markdown
Collaborator

  • Buffer log messages that are sent before subscribers are connected
  • Include working directory in 'running build command' message
  • Lower log level of 'building' message to Debug

phil-opp added 3 commits July 16, 2025 14:20
The initial messages might contain important information.
There will be a 'running build command' message with more details later.
@phil-opp
Copy link
Copy Markdown
Collaborator Author

@haixuanTao This PR is unrelated to our discussion in https://github.com/orgs/dora-rs/discussions/1074, so I think we can merge it. The changes of this PR should be useful in general.

Copy link
Copy Markdown
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

Thanks!

@phil-opp phil-opp merged commit 591aaad into main Jul 23, 2025
153 checks passed
@phil-opp phil-opp deleted the improve-logging branch July 23, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants