Merged
Conversation
Collaborator
Author
|
Merging to avoid accidental release of #1064. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The working directory deliberatly included the session ID in distributed settings to avoid conflicts when multiple dataflows are run on the same daemon.
The session ID is a unique identifier created for each dataflow.yaml file. By using this ID as part of the working directory, we can ensure that no other dataflow is running in the same directory. Sharing a working directory between multiple distinct dataflows could easily lead to unexpected behavior, e.g. by overwriting files of the other dataflow run. So it's better to avoid this.
By using the session ID, the daemon will still be able to reuse build artifacts etc of previous dataflow runs. So incremental compilation still works.
Reverts #1064