Removing support for macos x86 in order to unpin macos version#1048
Merged
haixuanTao merged 1 commit intomainfrom Jul 9, 2025
Merged
Removing support for macos x86 in order to unpin macos version#1048haixuanTao merged 1 commit intomainfrom
haixuanTao merged 1 commit intomainfrom
Conversation
8205906 to
bdc2356
Compare
Collaborator
|
Wouldn't it be enough to remove the |
Collaborator
Author
|
We could but Macbook Intel is going end of line soon and I kind of want to depreciate the node hub for it because Macbook Github action are slow and it doesn't really adds that much value |
Collaborator
|
I think some Intel MacBooks will keep receiving security updates for a few years. But I'm also fine with dropping support right now if nobody objects. |
Collaborator
Author
|
I understand, yet I don't feel we're able to provide the level of service people expect on it. Let's remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes macOS version pinning on Maturin that makes it the prebuilt will not installable on other macOS version.
I believe the original error is due to macOS x86 and I think it's time to remove support for it.