Fix spawning runtime through python when it is installed with pip#1011
Merged
haixuanTao merged 4 commits intomainfrom Jun 3, 2025
Merged
Fix spawning runtime through python when it is installed with pip#1011haixuanTao merged 4 commits intomainfrom
haixuanTao merged 4 commits intomainfrom
Conversation
b836e50 to
42b3509
Compare
phil-opp
reviewed
May 28, 2025
phil-opp
reviewed
May 28, 2025
phil-opp
reviewed
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #900 by checking the current exe of the daemon.
If the daemon is running on python => spawn the runtime on python.
If the daemon is running on a dora binary => use current dora binary.
Alternative to #940