refactor(tracing): use builder style#1009
Merged
haixuanTao merged 1 commit intodora-rs:mainfrom Jun 2, 2025
Merged
Conversation
Collaborator
|
FYI, I fixed the CI/CD within #1008, would it be possible to rebase on top of it! Thanks for the PR |
This was referenced May 27, 2025
fix: logging thread block
Contributor
Author
|
Done. |
Collaborator
|
Very sorry. Just want to merge couple of older PR first, before coming back to this but this looks very promising! |
haixuanTao
approved these changes
Jun 2, 2025
Collaborator
haixuanTao
left a comment
There was a problem hiding this comment.
Looks great! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the tracing initialization to use the builder-style API, improving configurability and clarity. Additionally, it removes the blocking
std::io::stdout-based tracing layer used in theNode, which previously caused log output to hang in async contexts (Fix #1001).Finally, several function names with misleading semantics have been renamed for clarity.