Skip to content

bump: :lang org +roam2 #6315

Closed
fosskers wants to merge 1 commit intodoomemacs:masterfrom
fosskers:colin/bump-org-roam-narrow-fix
Closed

bump: :lang org +roam2 #6315
fosskers wants to merge 1 commit intodoomemacs:masterfrom
fosskers:colin/bump-org-roam-narrow-fix

Conversation

@fosskers
Copy link
Copy Markdown
Contributor

@fosskers fosskers commented Apr 18, 2022

This PR bumps the org-roam pin to include a fix for the error spam when saving in a narrowed region.

See also org-roam/org-roam#2159

@fosskers fosskers changed the title bump(org): fix Roam's on-save errors when narrowed bump: :lang org +roam2 Apr 18, 2022
@iyefrat iyefrat added module:lang/org Pertains to Doom's :lang org module is:update An effort to catch up with changes made elsewhere labels May 6, 2022
iyefrat
iyefrat requested changes May 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@iyefrat iyefrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the commit to bump: org-roam? The commit format doesn't distinguish packages that are in feature flags. The linter just doesn't check the bump scope yet (see here)

@fosskers fosskers requested a review from a team as a code owner May 11, 2022 18:08
@hlissner hlissner added the was:moved Is, was, or will be addressed elsewhere label May 26, 2022
@hlissner hlissner added this to the modules v22.05 milestone May 26, 2022
@hlissner hlissner added the re:packages Pertains to package & dependency management label Jun 17, 2022
@hlissner hlissner closed this in 3733861 Jun 17, 2022
@fosskers fosskers deleted the colin/bump-org-roam-narrow-fix branch June 17, 2022 16:55
@hlissner
Copy link
Copy Markdown
Member

hlissner commented Jun 17, 2022

The :lang org module was overdue a larger bump, so I merged this into 3733861. Thanks for bringing it to my attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iyefrat iyefrat iyefrat approved these changes

Assignees

No one assigned

Labels

is:update An effort to catch up with changes made elsewhere module:lang/org Pertains to Doom's :lang org module re:packages Pertains to package & dependency management was:moved Is, was, or will be addressed elsewhere

Projects

None yet

Milestone

modules v22.06

Development

Successfully merging this pull request may close these issues.

3 participants

@fosskers @hlissner @iyefrat