Skip to content
This repository was archived by the owner on May 7, 2023. It is now read-only.

Add diagram#285

Merged
hyochan merged 2 commits intohyochan:masterfrom
daadaadaah:doc/add-diagram
Oct 18, 2020
Merged

Add diagram#285
hyochan merged 2 commits intohyochan:masterfrom
daadaadaah:doc/add-diagram

Conversation

@daadaadaah
Copy link
Copy Markdown
Contributor

@daadaadaah daadaadaah commented Oct 15, 2020 •
edited
Loading

Specify project

server

Description

  • Add a diagram that can easily understand the overall structure.

Related Issues

x

Tests

x

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@daadaadaah
Copy link
Copy Markdown
Contributor Author

daadaadaah commented Oct 15, 2020 •
edited
Loading

I drew a diagram that can easily understand the overall structure. Hope this diagram helps other contributors.
If this diagram helps, I'd like to add it to the hackatalk-website too, what do you think?
If it is added, it will be added to this part.

스크린샷 2020-10-15 오후 4 38 19

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   73.74%   73.74%           
=======================================
  Files          54       54           
  Lines         876      876           
  Branches       79       79           
=======================================
  Hits          646      646           
  Misses        195      195           
  Partials       35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fef05...ab6f831. Read the comment docs.

@hyochan
Copy link
Copy Markdown
Owner

hyochan commented Oct 15, 2020

I drew a diagram that can easily understand the overall structure. Hope this diagram helps other contributors.
If this diagram helps, I'd like to add it to the hackatalk-website too, what do you think?
If it is added, it will be added to this part.

스크린샷 2020-10-15 오후 4 38 19

It would be great to have it there too! Thanks for the contribution.

@daadaadaah
Copy link
Copy Markdown
Contributor Author

daadaadaah commented Oct 15, 2020 •
edited
Loading

@hyochan
Thanks for your approval.
I modified the diagram to correct the typo in the diagram. 😅

hyochan
hyochan suggested changes Oct 16, 2020
View reviewed changes
Copy link
Copy Markdown
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase correctly. U are changing lots of files that are not in your purpose.

@daadaadaah daadaadaah requested a review from hyochan October 16, 2020 16:36
hyochan
hyochan approved these changes Oct 18, 2020
View reviewed changes
Copy link
Copy Markdown
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan merged commit 0c63663 into hyochan:master Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hyochan hyochan hyochan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daadaadaah @hyochan