This repository was archived by the owner on May 7, 2023. It is now read-only.
Update generated path for schema.graphql#171
Merged
hyochan merged 1 commit intohyochan:masterfrom Jul 25, 2020
daadaadaah:master
Merged
Update generated path for schema.graphql#171hyochan merged 1 commit intohyochan:masterfrom daadaadaah:master
hyochan merged 1 commit intohyochan:masterfrom
daadaadaah:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 68.08% 68.08%
=======================================
Files 24 24
Lines 448 448
Branches 33 33
=======================================
Hits 305 305
Misses 130 130
Partials 13 13
Continue to review full report at Codecov.
|
hyochan
approved these changes
Jul 25, 2020
Owner
hyochan
left a comment
There was a problem hiding this comment.
👍 Ah! Nice catch. This has been changed since after we've migrated to Prisma2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify project
Server
Description
How about you changing the generated path for schema.graphql from
/serverto/server/src/generated?I think it is better to manage everything generated by nexus in the generated folder at once.
In the previous project, it was managed in one place.
If you have any other opinion, please speak freely.
Tests
None
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn lint && yarn tscyarn testoryarn test -uif you need to update snapshot.