Fix iteration condition for end_pos

dongwook-chan · dongwook-chan · commit 67d3a71e1235 · 2021-10-16T17:17:17.000+09:00
* Binlog event at end_pos is the last event to be read. (end_pos is inclusive)
* iter() ends when fetch_one() returns None.
diff --git a/pymysqlreplication/binlogstream.py b/pymysqlreplication/binlogstream.py
@@ -419,8 +419,7 @@ def __connect_to_stream(self):
         self.__connected_stream = True
 
     def fetchone(self):
-        should_continue = True
-        while should_continue:
+        while True:
             if not self.__connected_stream:
                 self.__connect_to_stream()
 
@@ -474,9 +473,9 @@ def fetchone(self):
             elif binlog_event.log_pos:
                 self.log_pos = binlog_event.log_pos
 
-            if self.end_log_pos and self.log_pos >= self.end_log_pos:
+            if self.end_log_pos and self.log_pos > self.end_log_pos:
                 # We're currently at, or past, the specified end log position.
-                should_continue = False
+                return None
 
             # This check must not occur before clearing the ``table_map`` as a
             # result of a RotateEvent.
