chore: use subtests in all unit tests#161
Open
Ozoniuss wants to merge 1 commit intodominikbraun:mainfrom
Open
Conversation
d902873 to
d73960d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes all (remaining) unit tests to use subtests. I pretty much followed the same implementation that some were already using, which is the same as the one from Dave Cheney's blog blog, or one of your own repositories.
This PR is very big, so I did not change anything else except putting the original tests into subtests and fix three (likely) writing issues. To make it easy to find them, see:
graph_test.go(changed*directedto*undirected)path_test.goSome other considerations:
continuestatements witht.SkipNow()gofmtfrom within Vscode, and some minor formatting differences may show up on the diff. Let me know if you have any formatter preferencescloses #68