Avoid startup dependency on AXHost DLL#1327
Merged
Merged
Conversation
No material changes to API. See [Scintilla History](https://www.scintilla.org/ScintillaHistory.html)
If the AXHost library, DolphinAX8.dll, cannot be loaded, then image startup fails. Since this is an optional component, it would be much better to fail when attempting to use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AXHost DLL is optional and its absence should only cause a failure if an attempt is made to actually use it.
This mitigates #1323. Although the DLL should be added to the setup, this should prevent failure on initial startup following installation.
Contains a few other small low-impact changes. Often the Scintilla upgrades are impactful, but in this case there is no API change.