Upgrade to Scintilla 5.5.3#1313
Merged
Merged
Conversation
blairmcg
commented
Dec 1, 2024
Contributor
- Ability to set style of auto-completion list. This is global though, i.e. applies to all items in the list. It would be nice to be able to add a style for each item, perhaps in a similar way to how the item icons are set as part of the data for each entry, but currently the control offers only the single setting.
- Support for condensed/expanded fonts as part of the text styles. This only works when DirectWrite drawing technology is used, and there is limited font support: Very few fonts have sub-styles with spacing adjustments, and if they do only a limited subset of the spacings. To make matters worse, when using GDI drawing tech one accesses the fonts with adjusted pitch by specifying it as part of the font name, e.g. 'Bahnschrift Condensed', but this does not work DirectWrite. Conversely font spacing settings for the text style are ignored when using GDI drawing. It may be possible to abstract away from this inconsistency in the Dolphin wrapper, but it would probably be easier to fix at the (OSS) Scintilla level. In summary, this is currently of limited utility, and (worse) is inconsistently implemented.
- Fix for a bug introduced by d44818d as part of the high DPI work, that using the font dialog to alter an existing font aspect modifies the internal LOGFONT structure of the existing font. If that font is a shared item, e.g. the icon title font, then there is the unfortunate global side effect of the shared font becoming modified for all of its uses.
- Fix an old bug (it's broken in DX6) that the point size spinner buttons in the Scintilla TextStyle presenter/dialog do not function.
- Some other minor changes from the last three Scintilla releases, e.g. line indent and unindent commands, ability to specify the separator for multiple selections copied to the clipboard, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.