Fix print dialog in Windows 11 and split out common dialogs to own packages#1243
Merged
Conversation
…ckages Microsoft have made the Unified Print Dialog (UPD) the default in Windows 11. Although the UPD looks more in keeping with the general UI style of Windows 11, it (frankly) doesn't work very well for Win32 apps, e.g. the preview pane is always just blank and the page ranges, etc, don't respect the data passed in. The facility to change a setting such as the selected printer, Apply, and then Cancel, is also completely absent. The extensibility interfaces, IPrintDialogCallback and IPrintDialogServices, are also completely missing. For these reasons it makes sense to revert to the legacy dialog by default. Implementation of IPrintDialogCallback for PRINTDLGEXW had been left as a TODO for some time. Also this doesn't buy much in and of itself, it was necessary to enable adoption of the new PrintDlgEx API, which has richer capabilities and has been the preferred API for many years (since Vista). Migration to use of Unicode was also missing from the printer dialog integration, so this has also been done. Finally, all the separate common dialogs have now been split out into their own packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft have made the Unified Print Dialog (UPD) the default in Windows 11. Although the UPD looks more in keeping with the general UI style of Windows 11, it (frankly) doesn't work very well for Win32 apps, e.g. the preview pane is always just blank and the page ranges, etc, don't respect the data passed in. The facility to change a setting such as the selected printer, Apply, and then Cancel, is also completely absent. The extensibility interfaces, IPrintDialogCallback and IPrintDialogServices, are also completely missing. For these reasons it makes sense to revert to the legacy dialog by default.
Implementation of IPrintDialogCallback for PRINTDLGEXW had been left as a TODO for some time. Also this doesn't buy much in and of itself, it was necessary to enable adoption of the new PrintDlgEx API, which has richer capabilities and has been the preferred API for many years (since Vista). Migration to use of Unicode was also missing from the printer dialog integration, so this has also been done.
Finally, all the separate common dialogs have now been split out into their own packages.