Fix browsing of refs/defs to vars broken by recent command query changes#1219
Merged
Conversation
…ompile When loading code, the warnings that commandQuery: annotations refer to handler methods that are not defined by the class owning the command are misleading, since these are likely due to load-order rather than an error. The warning is intended to help avoid creating invalid handler definitions while coding interactively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, only generate warnings for missing command queries from interactive compile. When loading code, the warnings that commandQuery: annotations refer to handler methods that are not defined by the class owning the command are misleading, since these are likely due to load-order rather than an error. The warning is intended to help avoid creating invalid handler definitions while coding interactively.