Inline expression prompts should offer option to show changes#1212
Merged
Conversation
Whether or not an expression is inlined or assigned to a temporary affects whether or not an inline operation is a true temporary. Inlining the expression may result in an operation being performed multiple times, which will change behaviour if the operation has side effects. I usually choose to inline, and then inspect the result to see whether to undo or not. An easier option would be to choose to see the proposed changes, and then cancel if inlining the expression wasn't the right choice after all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether or not an expression is inlined or assigned to a temporary affects whether or not an inline operation is a true temporary. Inlining the expression may result in an operation being performed multiple times, which will change behaviour if the operation has side effects. I usually choose to inline, and then inspect the result to see whether to undo or not. An easier option would be to choose to see the proposed changes, and then cancel if inlining the expression wasn't the right choice after all.