Skip to content

EditableListViewColumn invalidation sometimes incomplete #1328

Description

@rko281

The rectangle used to invalidate an EditableListViewColumn is calculated incorrectly where its EditableListView is not at the top of its containing view, causing incomplete redrawing.

To Reproduce

Evaluate:

shell := ShellView new create.
shell rectangle: (100 @ 100 extent: 300 @ 400).
shell show.

elv := ListPresenter loadViewResource: 'Editable list view' inContext: shell. 
elv 
	model: (ListModel withAll: (1 to: 10));
	position: 0@90;
	show;
	onViewOpened.

"Flush any pending invalidation"
SessionManager current inputState pumpMessages.

elv rowBackcolor: Color red.
elv primaryColumn invalidate

Expected behavior
All items should be redisplayed with the red background color following column invalidation.

Actual behavior
Only lower items are redrawn; upper items remain with the default background color:

Image

Dolphin 7.2.2
Windows 11 on Mac Silicon under VMWare

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions