-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add AMD registration as an option. #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
57c2029
Add AMD registration as an option.
jrburke 786d453
pass root to factory function.
jrburke b18dd4f
Merge branch 'master' of https://github.com/documentcloud/backbone in…
jrburke dba12e1
Some small consistency fixes as suggested by jdalton
jrburke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way to break out this define function? putting it inline seems weird to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbranyen, here is alternate path that could be taken for the patch. It still means passing a function into an anonymous, immediately executed function, but it may be aesthetically pleasing:
If you would rather see this approach taken, I'll do a different branch with this approach today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and did a branch that uses this different registration approach, you can do the compare here. It passes the tests, including the simple node one and the requirejs-based one I have in a test branch.
If you prefer I do a pull with this new optamd2 branch instead of this pull request, then I will close out this pull request and open another with that branch.