Skip to content

feat: add two factor auth feature#643

Merged
Mythie merged 46 commits intodocumenso:feat/refreshfrom
G3root:two-factor-auth
Dec 1, 2023
Merged

feat: add two factor auth feature#643
Mythie merged 46 commits intodocumenso:feat/refreshfrom
G3root:two-factor-auth

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Nov 10, 2023 •
edited
Loading

simple demo of the auth flow

Screencast.2023-11-10.07.57.50.webm

G3root added 30 commits November 6, 2023 13:06
@G3root
feat: add encryption utility function
abb7781
@G3root
feat: add 2fa fields
0f26d44
@G3root
feat: add setup 2fa route
f20967d
@G3root
feat: add enable procedure
b3d9721
@G3root
feat: add verify password procedure
827e4f2
@G3root
fix: secret encoding
b7e42ea
@G3root
feat: add turbo.json
c68e0b2
@G3root
feat: add example env
4f30a14
@G3root
feat: use trpc error
3a794a8
@G3root
feat: add disable 2fa procedure
efc1093
@G3root
feat: use trpc error
67d0f98
@G3root
feat: use trpc error code
bfc215c
@G3root
feat: add new error codes
49011ca
@G3root
feat: add password check dialog
c9e7df2
@G3root
chore: add packages
97e9401
@G3root
feat: add encryption key util
39bef53
@G3root
feat: add verify 2factor util
67ec40b
@G3root
feat: add get backup codes util
827903a
@G3root
feat: use the new util
7ef66a4
@G3root
chore: add new error code
d8ce2ed
@G3root
fix: reset on complete
0ce4213
@G3root
feat: add 2fa setup dialog
2bd12ec
@G3root
feat: add recovery codes dialog
6718222
@G3root
feat: add backup code to schema
4aaf525
@G3root
feat: add verify backup utility
02d24fe
@G3root
feat: format backup code
c863509
@G3root
feat: add authenticate 2fa utility
7e21873
@G3root
feat: use authenticateTwoFactorAuth utility
ad17664
@G3root
feat: add new error codes
eb3d9cd
@G3root
chore: remove format
eda8e24
@vercel
Copy link
Copy Markdown

vercel bot commented Nov 10, 2023

@G3root is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 10, 2023 •
edited
Loading

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@Mythie
Copy link
Copy Markdown
Collaborator

Mythie commented Nov 10, 2023

Looks like this could be huge Nafees! I'll review personally but may need some time to do so 🙌🏻

@Mythie Mythie self-assigned this Nov 10, 2023
@Mythie Mythie self-requested a review November 10, 2023 06:40
catalinpit
catalinpit reviewed Nov 17, 2023
View reviewed changes
@Mythie
Copy link
Copy Markdown
Collaborator

Mythie commented Nov 28, 2023

It's me! Reviewing now 😎

@Mythie
refactor: tidy code and improve encryption
6cdff7a 
I really wish I did this as more than one commit.
- Overhalled encryption to use the `@noble` packages
- Changed from AES-GCM to xchacha
- Tidied overall code
@Mythie
Copy link
Copy Markdown
Collaborator

Mythie commented Nov 30, 2023

Honestly that was some seriously awesome work! 🚀

I've just got some merge conflicts and a tiny bit more tidying of code I added to fix up and it's good to go 😄

/tip 300

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Nov 30, 2023

🎉🎈 @G3root has been awarded $300! 🎈🎊

@algora-pbc algora-pbc bot added the 💰 Rewarded Set by Algora after bounty is rewarded to user label Nov 30, 2023
@Mythie Mythie merged commit 8d0e815 into documenso:feat/refresh Dec 1, 2023
@Mythie Mythie changed the title feat: add Two factor auth feature feat: add two factor auth feature Dec 1, 2023
Mythie pushed a commit that referenced this pull request Dec 1, 2023
@G3root @Mythie
feat: add two factor auth (#643)
792158c 
Add two factor authentication for users who wish to enhance the security of their accounts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catalinpit catalinpit catalinpit left review comments

@Mythie Mythie Mythie approved these changes

Assignees

@Mythie Mythie

Labels

💰 Rewarded Set by Algora after bounty is rewarded to user

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@G3root @Mythie @catalinpit