Skip to content

chore: add some eslint rules#344

Merged
Mythie merged 12 commits intodocumenso:feat/refreshfrom
G3root:eslint-plugins
Nov 14, 2023
Merged

chore: add some eslint rules#344
Mythie merged 12 commits intodocumenso:feat/refreshfrom
G3root:eslint-plugins

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Sep 4, 2023

What this PR do ?

  • Enforces explicit type imports (this should help with unnecessary bundling of some imports while using as a type)
  • add auto fix for the unused imports
  • added a script for eslint fix
  • added a prettier ignore file

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 4, 2023

@G3root is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

G3root
G3root commented Sep 4, 2023
View reviewed changes
G3root
G3root commented Sep 4, 2023
View reviewed changes
G3root
G3root commented Sep 4, 2023
View reviewed changes
@adithyaakrishna
Copy link
Copy Markdown
Contributor

adithyaakrishna commented Sep 4, 2023

There should be a separate role for eslint handling, probably Linting Engineer? 😂

Mythie
Mythie reviewed Sep 4, 2023
View reviewed changes
Mythie
Mythie reviewed Sep 4, 2023
View reviewed changes
Mythie
Mythie reviewed Sep 4, 2023
View reviewed changes
Mythie
Mythie reviewed Sep 4, 2023
View reviewed changes
packages/eslint-config/package.json Outdated
"dependencies": {
"@typescript-eslint/eslint-plugin": "^5.59.2",
"@typescript-eslint/parser": "^5.59.2",
"@typescript-eslint/eslint-plugin": "^6.5.0",
Copy link
Copy Markdown
Collaborator

@Mythie Mythie Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS moves too fast 😬

@Mythie
Copy link
Copy Markdown
Collaborator

Mythie commented Sep 5, 2023

I assume we also haven't run the lint:fix script yet in this PR? Once I'm happy with the changes I'd suggest we do that as a final commit before merge since it'll be annoying to review otherwise 😄

@Mythie
Copy link
Copy Markdown
Collaborator

Mythie commented Sep 5, 2023

/tip 50

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Sep 5, 2023

@G3root: You just got a $50 tip! 👉 Complete your Algora onboarding to collect your payment.

@G3root
Copy link
Copy Markdown
Contributor Author

G3root commented Sep 5, 2023 •
edited
Loading

@Mythie thanks for the tip ❤️. Please let me know when you're okay with this PR; I'll then open another one for the lint:fix script.

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Sep 5, 2023

🎉🎈 @G3root has been awarded $50! 🎈🎊

@algora-pbc algora-pbc bot added the 💰 Rewarded Set by Algora after bounty is rewarded to user label Sep 5, 2023
@Mythie
Copy link
Copy Markdown
Collaborator

Mythie commented Oct 31, 2023

I'll get this up to date and merged, thanks again @G3root 🫶🏻

@Mythie Mythie self-assigned this Oct 31, 2023
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 14, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@Mythie Mythie merged commit c2d7954 into documenso:feat/refresh Nov 14, 2023
@Mythie
Copy link
Copy Markdown
Collaborator

Mythie commented Nov 14, 2023

We did it! 🙌

Mythie pushed a commit that referenced this pull request Nov 15, 2023
@G3root @Mythie
chore: add some eslint rules (#344)
ca9c0d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mythie Mythie Mythie left review comments

Assignees

@Mythie Mythie

Labels

💰 Rewarded Set by Algora after bounty is rewarded to user

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@G3root @adithyaakrishna @Mythie