Skip to content

feat: use nextjs.js standalone output for improvised docker image#338

Merged
Mythie merged 6 commits intodocumenso:feat/refreshfrom
G3root:updated-docker
Nov 10, 2023
Merged

feat: use nextjs.js standalone output for improvised docker image#338
Mythie merged 6 commits intodocumenso:feat/refreshfrom
G3root:updated-docker

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Sep 1, 2023

No description provided.

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 1, 2023

@G3root is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

@G3root G3root mentioned this pull request Oct 2, 2023
Closed
@dguyen dguyen requested a review from Mythie October 3, 2023 01:15
catalinpit
catalinpit reviewed Oct 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@catalinpit catalinpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! Added one small comment

packages/prisma/package.json Outdated
"prisma:migrate-dev": "prisma migrate dev",
"prisma:migrate-deploy": "prisma migrate deploy"
"prisma:migrate-deploy": "prisma migrate deploy",
"post-install": "prisma generate"
Copy link
Copy Markdown
Member

@catalinpit catalinpit Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why duplicate the command under another name?

Copy link
Copy Markdown
Contributor Author

@G3root G3root Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out , this was committed by mistake

@Mythie
Copy link
Copy Markdown
Collaborator

Mythie commented Oct 31, 2023

Hey Nafees, I'd like to come back to this one. I've noticed a few changes to the container that I'm not sure I agree with, is there any reason we can't just use the older Dockerfile with the updated next config?

@G3root
Copy link
Copy Markdown
Contributor Author

G3root commented Nov 1, 2023

Hey Nafees, I'd like to come back to this one. I've noticed a few changes to the container that I'm not sure I agree with, is there any reason we can't just use the older Dockerfile with the updated next config?

the older docker file is just fine, but it has a few issues, such as packages are installed twice and final size of the image is 2.08GB. whereas the standalone output results in an image size of only 295MB. inorder to use the standalone build we have to copy some files from .next/static and .next/standalone folder manually, so older docker file cannot be used.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 10, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@Mythie
Copy link
Copy Markdown
Collaborator

Mythie commented Nov 10, 2023

Hey Nafees, I'd like to come back to this one. I've noticed a few changes to the container that I'm not sure I agree with, is there any reason we can't just use the older Dockerfile with the updated next config?

the older docker file is just fine, but it has a few issues, such as packages are installed twice and final size of the image is 2.08GB. whereas the standalone output results in an image size of only 295MB. inorder to use the standalone build we have to copy some files from .next/static and .next/standalone folder manually, so older docker file cannot be used.

Apologies for the delay once again, I corrected the parts I wasn't so agreeable on and we're in a good state now!

Awesome work, we appreciate it 🫶🏻

/tip 50

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Nov 10, 2023

🎉🎈 @G3root has been awarded $50! 🎈🎊

@algora-pbc algora-pbc bot added the 💰 Rewarded Set by Algora after bounty is rewarded to user label Nov 10, 2023
@Mythie Mythie merged commit d2a6cbd into documenso:feat/refresh Nov 10, 2023
Mythie pushed a commit that referenced this pull request Nov 12, 2023
@G3root @Mythie
feat: use nextjs.js standalone output for improvised docker image (#338)
d6ae0b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catalinpit catalinpit catalinpit left review comments

@Mythie Mythie Awaiting requested review from Mythie

Assignees

No one assigned

Labels

💰 Rewarded Set by Algora after bounty is rewarded to user

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@G3root @Mythie @catalinpit