Improvement Description
Twice now we've had bugs due to floating promises which were entirely human error (my fault), to handle this we should add eslint rules that cause floating promises and lack of awaits to turn into lint errors.
Rationale
This would stop a whole class of errors that are easy to miss during code review since you aren't sure whether a given method is sync or async.
Proposed Solution
Add the appropriate eslint rules to deal with lack of awaits and floating promises.
Alternatives (optional)
N/A
Additional Context
N/A
Checklist
DOC-312
Improvement Description
Twice now we've had bugs due to floating promises which were entirely human error (my fault), to handle this we should add
eslintrules that cause floating promises and lack of awaits to turn into lint errors.Rationale
This would stop a whole class of errors that are easy to miss during code review since you aren't sure whether a given method is sync or async.
Proposed Solution
Add the appropriate
eslintrules to deal with lack of awaits and floating promises.Alternatives (optional)
N/A
Additional Context
N/A
Checklist
DOC-312