Temporarily remove deprecations about ns move#87
Merged
greg0ire merged 1 commit intodoctrine:1.3.xfrom Jan 9, 2020
Merged
Conversation
Member
Author
|
To be merged if people in https://github.com/orgs/doctrine/teams/doctrinecore/discussions/11 agree to do so. |
We want to give ourselves time to address them in the other packages we own and that consume this library. Not doing so generates a lot of support from people asking how they can fix the deprecations in their application, which they cannot. This commit should be reverted in a following release, when at least all of our packages have made the move.
91d88fe to
132709c
Compare
beberlei
approved these changes
Jan 9, 2020
Member
beberlei
left a comment
There was a problem hiding this comment.
Idea is to re-release the deprecations with version 1.4.0 in a branch that is entirely compatible with 1.3.x, so everyone can stick with 1.3 until doctrine/orm or doctrine/mongo-odm raises the requirement itself to persistence 1.4
alcaeus
approved these changes
Jan 9, 2020
ostrolucky
approved these changes
Jan 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to give ourselves time to address them in the other packages we
own and that consume this library.
Not doing so generates a lot of support from people asking how they can
fix the deprecations in their application, which they cannot. This
commit should be reverted in a following release, when at least all of
our packages have made the move.