Show more details about errors in PHPUnit#454
Merged
GromNaN merged 3 commits intodoctrine:4.1.xfrom Oct 23, 2025
Merged
Conversation
greg0ire
reviewed
Oct 16, 2025
7d6b6a7 to
89e25b7
Compare
greg0ire
reviewed
Oct 16, 2025
b312f48 to
855487c
Compare
greg0ire
reviewed
Oct 16, 2025
phpunit.xml.dist
Outdated
| beStrictAboutOutputDuringTests="true" | ||
| displayDetailsOnPhpunitDeprecations="true" | ||
| displayDetailsOnTestsThatTriggerDeprecations="true" | ||
| displayDetailsOnTestsThatTriggerErrors="true" |
Member
There was a problem hiding this comment.
Regarding displayDetailsOnTestsThatTriggerErrors: what's the difference between having it and the default behavior?
Member
There was a problem hiding this comment.
@GromNaN I tried throw \Error inside a test, and couldn't find a difference with or without this setting, so let's remove it?
Member
Author
There was a problem hiding this comment.
The different is with trigger_error('Hello World', E_USER_ERROR).
PHPUnit 12.4.1 by Sebastian Bergmann and contributors.
Runtime: PHP 8.4.8
Configuration: /Users/jerome/Develop/doctrine-persistence/phpunit.xml.dist
E 1 / 1 (100%)
Time: 00:00.006, Memory: 16.00 MB
There was 1 error:
1) ErrorTest::testError
E_USER_ERROR was triggered
tests/ErrorTest.php:9
+ --
+
+ 1 test triggered 1 error:
+
+ 1) tests/ErrorTest.php:9
+ Hello World
+
ERRORS!
Tests: 1, Assertions: 0, Errors: 2, Deprecations: 1.
Member
There was a problem hiding this comment.
Ah nice! I guess it could be useful to have the "Hello World" part.
Member
Author
There was a problem hiding this comment.
This was my test:
<?php
use PHPUnit\Framework\TestCase;
class ErrorTest extends TestCase
{
public function testError(): void
{
trigger_error('Hello World', E_USER_ERROR);
}
}
greg0ire
previously approved these changes
Oct 20, 2025
SenseException
previously approved these changes
Oct 20, 2025
xabbuh
reviewed
Oct 21, 2025
855487c to
22dfdbe
Compare
Member
Author
|
We get deprecation with PHP 8.1, without message |
Member
|
When the job uses lowest dependencies, PHPUnit should probably be instructed to not fail when detecting deprecations using the |
7fcb327 to
2a773aa
Compare
d5a7a1d to
5569ecd
Compare
5569ecd to
6e1cf15
Compare
Member
Author
|
I updated the Action. PR is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #450 (comment)