fix compatibility with PHP 8.5#437
Merged
greg0ire merged 1 commit intodoctrine:3.4.xfrom Sep 29, 2025
Merged
Conversation
greg0ire
previously approved these changes
Sep 26, 2025
Member
greg0ire
left a comment
There was a problem hiding this comment.
LGTM after reading https://www.php.net/manual/en/reflectionproperty.setaccessible.php
Member
Author
|
By the way, I wonder if a job for PHP 8.4 is missing intentionally or if that’s just an oversight and should be added. |
GromNaN
previously approved these changes
Sep 26, 2025
Member
Yes, I think nobody added it when PHP 8.4 was released. It was only added for 4.1 in 5eece5b. We can add both 8.4 and 8.5? |
Member
Author
8.4 should not be an issue. Not sure about 8.5 as I have no idea what the Doctrine policy is for adding jobs for yet to be released PHP versions. |
Member
|
PHP 8.5-RC1 being released, there should be no breaking changes. |
Member
|
Let's add both. |
Member
Author
|
both added |
GromNaN
approved these changes
Sep 27, 2025
SenseException
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.